Skip to content

T7857: Add Realtek RTL8126 5Gbit driver - #1043

Merged
sever-sever merged 1 commit into
vyos:currentfrom
boretom:feature/add-realtek-8126-source-mirror
Oct 7, 2025
Merged

T7857: Add Realtek RTL8126 5Gbit driver#1043
sever-sever merged 1 commit into
vyos:currentfrom
boretom:feature/add-realtek-8126-source-mirror

Conversation

@boretom

@boretom boretom commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Add Realtek RTL8126 5Gbit driver

Based on a (5 month old) forum thread: add the Realtek 8126 5Gbit driver, similar how the Realtek 8152 was added.

The file r8126-10.016.00.tar.bz2 is expected in packages.vyos.net/source-mirror and has to be fetch from https://www.realtek.com/Download/List?cate_id=584

The SHA256 of the file tested with:
50c8d3d49592d2e8f372bd7ece8e7df9b50a71b055c077d42eacc42302914440 r8126-10.016.00.tar.bz2

My test included compiling it, add the DEB to the build process and modprobe r8126 it on the created custom ISO. The OP of the forum thread reported success from basic tests (back in April '25).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7857

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions

github-actions Bot commented Sep 23, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Sep 23, 2025

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions github-actions Bot added the current VyOS rolling release label Sep 23, 2025
@boretom

boretom commented Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

vyosbot added a commit to vyos/vyos-cla-signatures that referenced this pull request Sep 23, 2025
@boretom
boretom force-pushed the feature/add-realtek-8126-source-mirror branch from 3e0e496 to b63633e Compare September 23, 2025 17:48

@asklymenko asklymenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file r8126-10.016.00.tar.bz2 is uploaded to packages.vyos.net/source-mirror. The script works correctly on both ARM64 and AMD64 platforms. The only change required to make is to remove the following line to avoid confusion:
architecture_file: str = Path('../../../data/architectures/amd64.toml').read_text()

Comment thread scripts/package-build/linux-kernel/build-realtek-r8126.py Outdated
Signed-off-by: Thomas Kupper <thomas.kupper@gmail.com>
@boretom
boretom force-pushed the feature/add-realtek-8126-source-mirror branch from b63633e to 6d01ffa Compare October 6, 2025 06:44
@boretom
boretom requested a review from asklymenko October 6, 2025 06:47

@asklymenko asklymenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@c-po
c-po self-requested a review October 7, 2025 14:37

@c-po c-po left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package addition is straight forward and looks good to me. Tested by @asklymenko

@jestabro jestabro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build file looks good; package build ran successfully.

@sever-sever
sever-sever merged commit 0d562b7 into vyos:current Oct 7, 2025
8 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

6 participants